Skip to content

[Dependency Scanning][NFC] Associate single-shot scanner service lifetime with the owning compilation instance's ASTContext #75139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Jul 10, 2024

Resolves rdar://131388478

…time with the owning compilation instance's ASTContext

Resolves rdar://131388478
@artemcm artemcm requested a review from etcwilde July 10, 2024 20:50
@artemcm
Copy link
Contributor Author

artemcm commented Jul 10, 2024

@swift-ci test

@etcwilde
Copy link
Member

preset=asan
@swift-ci please test with preset macOS platform

Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should work. Just running a macOS ASAN build to make sure. If that passes, I think you're good to go. Thanks.

@artemcm artemcm merged commit a55beaa into swiftlang:main Jul 11, 2024
6 checks passed
@artemcm artemcm deleted the FixScanSourceLocUseAfterFree branch July 11, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants