[6.0] IRGen: Don't encode conditional requirements to Copyable as normal conformance requirement. #74605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nformance requirements. For new runtimes, this is redundant with the invertible requirement encoding, and for old runtimes, this breaks dynamic conformance checking because Copyable and Escapable aren't real protocols on those older runtimes. Fixes rdar://129857284.
|
@swift-ci Please test |
tbkka
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes a problem when extensions add conformances of standard library types such as
Optionalthat were retrofitted with non-Copyabletype support to protocols defined outside of the standard library which would cause dynamic protocol conformance lookup to fail when running on older OSes.Scope: Back deployment bug fix.
Issue: rdar://129857284
Original PR: #74604
Risk: Low. Fixes code to generate runtime metadata as it was generated for consumption by previous Swift runtime versions.
Testing: Swift CI
Reviewer: @slavapestov