Skip to content

🍒[5.10] Build-script preset: pr-apple-llvm-project-linux #74222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

etcwilde
Copy link
Contributor

@etcwilde etcwilde commented Jun 7, 2024

Cherry picking: #74156

Adding a preset for the pr-apple-llvm-project-linux PR test so that it is configurable without needing to modify CI directly.

Also fixing the linker that clang defaults to in order to avoid using the BFD linker and failing to link (relocations and private symbols).

etcwilde added 2 commits June 7, 2024 13:37
Moving the flags used to invoke build-script for
pr-apple-llvm-project-linux to a preset so that it can be configured
without modifying CI itself.
Clang is defaulting to the bfd linker in the PR job, resulting in test
failures due to failure to link. Switching it to gold.
@etcwilde
Copy link
Contributor Author

etcwilde commented Jun 7, 2024

@swift-ci please test

@etcwilde etcwilde merged commit 48015ab into swiftlang:release/5.10 Jun 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants