Build-script preset: pr-apple-llvm-project-linux #74156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
preset=pr_apple_llvm_project_linux |
|
@swift-ci please smoke test |
Moving the flags used to invoke build-script for pr-apple-llvm-project-linux to a preset so that it can be configured without modifying CI itself.
Clang is defaulting to the bfd linker in the PR job, resulting in test failures due to failure to link. Switching it to gold.
etcwilde
force-pushed
the
ewilde/llvm-linux-pr-test-preset
branch
from
97c6945 to
fce890d
Compare
|
preset=pr_apple_llvm_project_linux |
|
@swift-ci please smoke test |
compnerd
approved these changes
Jun 6, 2024
shahmishal
approved these changes
Jun 6, 2024
|
Let's cherry-pick this to 6.0, thanks! |
Cherry-picked here: #74162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a preset for the pr-apple-llvm-project-linux PR test so that it is configurable without needing to modify CI directly.
Also fixing the linker that clang defaults to in order to avoid using the BFD linker and failing to link (relocations and private symbols).
Related PR: swiftlang/llvm-project#8850