Skip to content

Build-script preset: pr-apple-llvm-project-linux #74156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

etcwilde
Copy link
Contributor

@etcwilde etcwilde commented Jun 5, 2024

Adding a preset for the pr-apple-llvm-project-linux PR test so that it is configurable without needing to modify CI directly.

Also fixing the linker that clang defaults to in order to avoid using the BFD linker and failing to link (relocations and private symbols).
Related PR: swiftlang/llvm-project#8850

@etcwilde etcwilde requested review from compnerd and shahmishal June 5, 2024 23:09
@etcwilde
Copy link
Contributor Author

etcwilde commented Jun 5, 2024

preset=pr_apple_llvm_project_linux
@swift-ci Please test with preset Linux Platform

@etcwilde
Copy link
Contributor Author

etcwilde commented Jun 5, 2024

@swift-ci please smoke test

etcwilde added 2 commits June 5, 2024 16:26
Moving the flags used to invoke build-script for
pr-apple-llvm-project-linux to a preset so that it can be configured
without modifying CI itself.
Clang is defaulting to the bfd linker in the PR job, resulting in test
failures due to failure to link. Switching it to gold.
@etcwilde etcwilde force-pushed the ewilde/llvm-linux-pr-test-preset branch from 97c6945 to fce890d Compare June 5, 2024 23:27
@etcwilde
Copy link
Contributor Author

etcwilde commented Jun 5, 2024

preset=pr_apple_llvm_project_linux
@swift-ci Please test with preset Linux Platform

@etcwilde
Copy link
Contributor Author

etcwilde commented Jun 5, 2024

@swift-ci please smoke test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct to me; definitely nice to be able to control this without changing the CI configuration.

@shahmishal
Copy link
Member

Let's cherry-pick this to 6.0, thanks!

@etcwilde
Copy link
Contributor Author

etcwilde commented Jun 6, 2024

Let's cherry-pick this to 6.0, thanks!

Cherry-picked here: #74162

@etcwilde etcwilde merged commit 4497c70 into swiftlang:main Jun 6, 2024
4 checks passed
@etcwilde etcwilde deleted the ewilde/llvm-linux-pr-test-preset branch June 6, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants