Skip to content

[6.0][lld] Allow opt-out from building lld via --skip-build-lld #74046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2024
Merged

[6.0][lld] Allow opt-out from building lld via --skip-build-lld #74046

merged 1 commit into from
Jun 5, 2024

Conversation

al45tair
Copy link
Contributor

Cherry pick of #73539.

rdar://129053233

@kubamracek @al45tair
Merge pull request swiftlang#73539 from kubamracek/lld-opt-out
307c32c 
[lld] Allow opt-out from building lld via --skip-build-lld
@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.0 labels May 31, 2024
@al45tair al45tair requested a review from a team as a code owner May 31, 2024 08:53
@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair
Copy link
Contributor Author

Explanation: Apparently in addition to #70715 (cherry picked as #73970), we need #73539 to avoid a problem created by the former.
Original PR: #73539
Risk: Low. Already on main.
Reviewed by: @bnbarham @krispymb @edymtt
Resolves: rdar://129053233
Tests: The Python build script tests were updated by this PR.

@al45tair
Copy link
Contributor Author

macOS PR testing failed because of:

warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'llvm/test/CodeGen/X86/apx/asm-constraint-jR.ll'
  'llvm/test/CodeGen/X86/apx/asm-constraint-jr.ll'

caused by llvm/llvm-project#92338, and apparently fixed in llvm/llvm-project#93794.

@al45tair
Copy link
Contributor Author

al45tair commented Jun 3, 2024

@swift-ci Please test macOS platform

@al45tair al45tair merged commit ae12ced into swiftlang:release/6.0 Jun 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edymtt edymtt edymtt approved these changes

@shahmishal shahmishal shahmishal approved these changes

@kubamracek kubamracek Awaiting requested review from kubamracek

Assignees
No one assigned
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@al45tair @edymtt @shahmishal @kubamracek