Skip to content

[lld] Allow opt-out from building lld via --skip-build-lld #73539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 10, 2024

Conversation

kubamracek
Copy link
Contributor

@kubamracek kubamracek commented May 9, 2024

rdar://126058593

@kubamracek kubamracek requested review from edymtt, bnbarham and krispymb May 9, 2024 16:19
@kubamracek
Copy link
Contributor Author

@swift-ci please test

Copy link
Contributor

@bnbarham bnbarham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

======================================================================
FAIL: test_default_value_build_lld (tests.build_swift.test_driver_arguments.TestDriverArgumentParser)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/build-user/swift/utils/build_swift/tests/build_swift/test_driver_arguments.py", line 91, in test
    self.assertEqual(default_value, parsed_value,
AssertionError: False != True : Invalid default value for "build_lld": False != True

======================================================================
FAIL: test_expected_options_exhaustive (tests.build_swift.test_driver_arguments.TestDriverArgumentParser)
Test that we are exhaustively testing all options accepted by the
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/build-user/swift/utils/build_swift/tests/build_swift/test_driver_arguments.py", line 411, in test_expected_options_exhaustive
    self.fail('non-exhaustive expected options, missing: {}'
AssertionError: non-exhaustive expected options, missing: {'--skip-build-lld'}

----------------------------------------------------------------------
Ran 1250 tests in 38.671s

FAILED (failures=2)

But otherwise 👍

@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek kubamracek enabled auto-merge May 9, 2024 23:01
@kubamracek kubamracek merged commit c09fa4e into swiftlang:main May 10, 2024
4 of 5 checks passed
al45tair pushed a commit to al45tair/swift that referenced this pull request May 31, 2024
[lld] Allow opt-out from building lld via --skip-build-lld
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants