Skip to content

[FixIt]: Diagnostic for use of plain protocol name in type position suggests some or any #73407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

saehejkang
Copy link
Contributor

@saehejkang saehejkang commented May 3, 2024

Changes Made

  • Logic added to add two new fixits when appropriate
  • Updated existing error message to add the some keyword
  • Added two new notes recommending replacements
  • Updated test files

Resolves #68284

@saehejkang saehejkang changed the title [FixIt]: Initial pass for protocol diagnosis Updates [FixIt]: Diagnostic for use of plain protocol name in type position suggests some or any May 3, 2024
@saehejkang
Copy link
Contributor Author

saehejkang commented May 3, 2024

looking for a quick passthrough before I continue working on this 👀 @AnthonyLatsis

@AnthonyLatsis AnthonyLatsis self-requested a review May 4, 2024 19:17
@saehejkang
Copy link
Contributor Author

@AnthonyLatsis ping for quick review

@AnthonyLatsis
Copy link
Collaborator

Superseded by #74197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostic for use of plain protocol name in type position should suggest some or any
2 participants