Skip to content

Disable tracing in xpcproxy #72591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Disable tracing in xpcproxy #72591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion include/swift/Runtime/TracingCommon.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ static inline bool shouldEnableTracing() {
return false;
if (__progname && (strcmp(__progname, "logd") == 0 ||
strcmp(__progname, "diagnosticd") == 0 ||
strcmp(__progname, "notifyd") == 0))
strcmp(__progname, "notifyd") == 0) ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a mistake here in the parenthesis placement - I'm fixing it in #72612.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tshortli The stray paren is also in #72593; presumably you'll cherry pick #72612 to the release/6.0 branch to fix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes will cherry pick.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

strcmp(__progname, "xpcproxy") == 0)
return false;
return true;
}
Expand Down