[Explicit Module Build] Execute module interface verification in a sub-invocation context #71416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
force-pushed
the
ExplicitInterfaceVerifyReadFlagsFix
branch
2 times, most recently
from
1d19c78 to
eb76257
Compare
|
@swift-ci smoke test |
tshortli
reviewed
Feb 6, 2024
test/ScanDependencies/explicit-module-map-typecheck-module-from-interface.swift
Outdated
Show resolved
Hide resolved
tshortli
approved these changes
Feb 6, 2024
artemcm
force-pushed
the
ExplicitInterfaceVerifyReadFlagsFix
branch
2 times, most recently
from
3947113 to
8760a87
Compare
xymus
approved these changes
Feb 6, 2024
|
@swift-ci smoke test |
|
@swift-ci test Windows platform |
…b-invocation context Otherwise, with `-explicit-interface-module-build` they do not read out/inherit compiler flags written in the interface itself. Resolves rdar://122418125
artemcm
force-pushed
the
ExplicitInterfaceVerifyReadFlagsFix
branch
from
8760a87 to
55cc29f
Compare
|
@swift-ci smoke test |
cachemeifyoucan
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, with
-explicit-interface-module-buildthey do not read out/inherit compiler flags written in the interface itself.Resolves rdar://122418125