[Sema] Avoid forming nested do expressions in if/switch bindings
#70987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
hborla,
slavapestov and
xedin
as code owners
In asserts builds this hits an assert that the feature isn't enabled, and in no-asserts builds this incorrectly allows `do` expressions to be used with the feature disabled. Note this only affects their use when nested in an `if`/`switch` that is used in a binding, we correctly handled the other cases. rdar://121193678
Contributor
Author
|
@swift-ci please smoke test |
xedin
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In asserts builds this hits an assert that the feature isn't enabled, and in no-asserts builds this incorrectly allows
doexpressions to be used with the feature disabled. Note this only affects their use when nested in anif/switchthat is used in a binding, we correctly handled the other cases.rdar://121193678