Fix @retroactive for conditional conformances, and more #70951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
AnthonyLatsis,
ahoppen,
bnbarham,
hamishknight,
hborla,
kavon,
rintaro and
xedin
as code owners
slavapestov
force-pushed
the
sendable-type-and-more
branch
from
4f7cdde to
d2b2555
Compare
In preparation for checkRequirements() asserting upon encountering type parameters. Should be NFC.
Passing in the declared interface type to checkConformance() here masked a silent failure where if the type declaration was generic and the conformance conditional, the conditional requirement check would fail. As a result, we did not diagnose the absence of @retroactive, nor the unnecessary presence of it. Since we only care about the existence of some conformance, we can use lookupConformance() instead.
I want to slim down ConformanceChecker because it doesn't really fit with request-driven resolution of witnesses. This is a first step towards that.
slavapestov
force-pushed
the
sendable-type-and-more
branch
from
d2b2555 to
5249432
Compare
slavapestov
changed the title
slavapestov
removed request for
a team,
AnthonyLatsis,
bnbarham,
hamishknight,
hborla,
kavon,
rintaro and
xedin
Contributor
Author
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@retroactiveone way or the other with conditional conformances.