[cxx-interop] Initial tests for std::function usage
#70772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
Contributor
|
yay! |
hyp
approved these changes
Jan 9, 2024
Contributor
hyp
left a comment
hyp
left a comment
There was a problem hiding this comment.
LG, not sure why it's failing :(
Contributor
Author
|
The Windows failure is interesting, I think we might be treating |
Contributor
Author
|
@swift-ci please smoke test |
1 similar comment
Contributor
Author
|
@swift-ci please smoke test |
This makes sure that `std::function` is imported consistently on supported platforms, and that it allows basic usage: calling a function with `callAsFunction`, initializing an empty function, and passing a function retrieved from C++ back to C++ as a parameter. rdar://103979602
egorzhdan
force-pushed
the
egorzhdan/std-function-initial-tests
branch
from
c8522eb to
2d0863a
Compare
Contributor
Author
|
@swift-ci please smoke test |
`clangSema.isCompleteType` checks for decl visibility according to the module visibility rules, which we don't actually need. What we need to check is whether the record has a definition – this is the check we already use elsewhere in ClangImporter. This makes sure that we can import `std::function` on Windows. rdar://103979602
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
The new failure on Windows: |
The test was passing by accident: we didn't properly check `std::pair` type for completeness, and assumed that it is incomplete. This updates the test to actually verify the behavior that is specified in the vision document.
Contributor
Author
|
@swift-ci please smoke test |
In libstdc++ 11, `std::pair` has a base class `std::__pair_base`, which defines a copy constructor. We still continue not treating `std::pair` as an owned type, just like on other platforms.
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
Hmm, adding explicit imports helps with the Windows failure... import CxxStdlib
import CxxStdlib.functionalIt seems there is something wrong with Clang Sema's module visibility check |
Contributor
Author
|
Ahhh we were missing |
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that
std::functionis imported consistently on supported platforms, and that it allows basic usage: calling a function withcallAsFunction, initializing an empty function, and passing a function retrieved from C++ back to C++ as a parameter.rdar://103979602