[Basic] hasFeature should succeed for promoted language features #70706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnbarham
requested review from
ahoppen,
CodaFi,
DougGregor,
hamishknight,
rintaro,
hborla,
slavapestov,
xedin and
tshortli
as code owners
|
@swift-ci please test |
bnbarham
force-pushed
the
should-have-feature
branch
from
c87bd3e to
b5edb1b
Compare
bnbarham
force-pushed
the
should-have-feature
branch
from
b5edb1b to
218ff42
Compare
bnbarham
force-pushed
the
should-have-feature
branch
from
218ff42 to
5fdd1f2
Compare
|
@swift-ci please test |
rintaro
approved these changes
Jan 4, 2024
Merge `$<Feature>` and `hasFeature` implementations.
- `$<Feature>` did not support upcoming language features.
- `hasFeature` did not support promoted language features and also
didn't take into account `Options` in `Features.def`.
Remove `Options` entirely, it was always one of three cases:
- `true`
- `langOpts.hasFeature`
- `hasSwiftSwiftParser`
Since `LangOptions::hasFeature` should always be used anyway, it's no
longer necessary. `hasSwiftSwiftParser` can be special cased when adding
the default promoted language features (by removing those features).
Resolves rdar://117917456.
bnbarham
force-pushed
the
should-have-feature
branch
from
5fdd1f2 to
d51c58a
Compare
|
@swift-ci please test |
DougGregor
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
$<Feature>andhasFeatureimplementations.$<Feature>did not support upcoming language features.hasFeaturedid not support promoted language features and also didn't take into accountOptionsinFeatures.def.Remove
Optionsentirely, it was always one of three cases:truelangOpts.hasFeaturehasSwiftSwiftParserSince
LangOptions::hasFeatureshould always be used anyway, it's no longer necessary.hasSwiftSwiftParsercan be special cased when adding the default promoted language features (by removing those features).Resolves rdar://117917456.