[NCGenerics] allow feature-guarded uses of ~Copyable #69821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavon
requested review from
ahoppen,
bnbarham,
CodaFi,
DougGregor,
rintaro,
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
kavon
force-pushed
the
ncgenerics-feature-guard-parsing
branch
2 times, most recently
from
0c09e2e to
f7dc938
Compare
|
@swift-ci please smoke test |
There are sometimes parsing stuations where we don't want to emit a parsing error, because of feature guarding. For example, if a Feature involves new syntax for a type, we must be able to parse both the true and false sides of an ifdef guarding that new syntax based on a Feature flag.
We need to delay the pre-NCGenerics errors about illegal uses of ~Copyable from Parse until Sema. Otherwise, such uses can't appear within a false
kavon
force-pushed
the
ncgenerics-feature-guard-parsing
branch
from
f7dc938 to
dbd17c5
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to delay the pre-NCGenerics errors about illegal uses of ~Copyable from Parse until Sema. Otherwise, such uses can't appear within a false #if-block.