Skip to content

Conversation

@al45tair
Copy link
Contributor

@al45tair al45tair commented Oct 6, 2023

Somehow since this passed PR testing, Builtin.int_trap() has changed from generating SIGILL to SIGTRAP. Accept either.

rdar://116584708

Somehow since this passed PR testing, `Builtin.int_trap()` has changed
from generating `SIGILL` to `SIGTRAP`.  Accept either.

rdar://116584708
@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.9 labels Oct 6, 2023
@al45tair al45tair requested a review from a team as a code owner October 6, 2023 17:13
@al45tair
Copy link
Contributor Author

al45tair commented Oct 6, 2023

@swift-ci Please test

@al45tair
Copy link
Contributor Author

al45tair commented Oct 6, 2023

Explanation: This test started failing in CI because fatalError() started generating SIGTRAP instead of SIGILL. Don't know why, but it doesn't actually matter — we should make the test more lenient.
Original PR: #69017
Reviewed by: @mikeash, @artemcm
Resolves: rdar://116584708
Tests: This modifies the test to make it more lenient.

@artemcm artemcm merged commit 16bbc61 into swiftlang:release/5.9.1 Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍒 release cherry pick Flag: Release branch cherry picks swift 5.9

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants