Skip to content

[5.9][SourceKit] Fix RPATH to lib/swift/host in SourceKit frameworks #68925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Oct 3, 2023

Cherry-pick #68807 into release/5.9

  • Explanation: SourceKit frameworks didn't have correct RPATH to lib/swift/host in the toolchain. All tests happened to work because the parent executables happened to have the RPATH to lib/swift/host. This is broken since [5.9][CMake] Support Macros in Linux #68190
  • Scope: SourceKit
  • Risk: Low, this only affects clients who wants to use SourceKit frameworks directly, and it only corrects RPATHs.
  • Testing: Current test suite passes. And fixes ASAN CI jobs failing.
  • Issues: rdar://115976985
  • Reviewer: Ben Barham (@bnbarham)

Relative path calculation to lib/swift/host was not correct.

rdar://115976985
(cherry picked from commit 88ec86f)
@rintaro rintaro requested a review from a team as a code owner October 3, 2023 00:01
@rintaro
Copy link
Member Author

rintaro commented Oct 3, 2023

@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Oct 5, 2023

Closing because 5.9 doesn't need this

@rintaro rintaro closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant