[Linux] Make the backtracing symbol reference conditional. #68799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the LSan builds, we disable the backtracer, which results in a link error because we completely remove the code from libswiftCore. rdar://116105222
|
@swift-ci Please test |
|
This is a cherry pick of #68798. |
|
Explanation: #68669 added a reference to a symbol in the backtracer's crash handling code. However, if the backtracer is disabled (as it is in LSan builds), that code is compiled out of the runtime, so the reference needed to be conditional. |
al45tair
added
🍒 release cherry pick
tbkka
approved these changes
Sep 27, 2023
al45tair
added a commit
to al45tair/swift
that referenced
this pull request
Oct 2, 2023
[Linux] Make the backtracing symbol reference conditional.
al45tair
added a commit
to al45tair/swift
that referenced
this pull request
Oct 2, 2023
[Linux] Make the backtracing symbol reference conditional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the LSan builds, we disable the backtracer, which results in a link error because we completely remove the code from libswiftCore.
rdar://116105222