[Linux] Force the inclusion of the backtracing code when static linking. #68669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we're statically linking the standard library, we need to force the inclusion of the backtracing code in the runtime, otherwise we don't get on-crash backtraces. Also, add a test to make sure that this works. rdar://115774613
|
@swift-ci Please smoke test |
mikeash
approved these changes
Sep 21, 2023
This was referenced Sep 21, 2023
tomerd
approved these changes
Sep 21, 2023
When we're building with host tools, we should use the host's swiftrt.o and not the one we've just built when we're trying to build tools that we will run on the host system. rdar://115774613
|
@swift-ci Please smoke test |
We want the static version of Dispatch here. If we don't use that version, we'll fail the tests on the release branches (but strangely not on main for some reason). rdar://115774613
|
@swift-ci Please smoke test |
This was referenced Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we're statically linking the standard library, we need to force the inclusion of the backtracing code in the runtime, otherwise we don't get on-crash backtraces.
Also, add a test to make sure that this works.
rdar://115774613