Skip to content

[docs] Fix cut off sentence and correct Throwing discarding task group docs #68791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 29, 2023
Merged

[docs] Fix cut off sentence and correct Throwing discarding task group docs #68791

merged 3 commits into from
Sep 29, 2023

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Sep 27, 2023

We cut off a sentence, this corrects that issue.

resolves rdar://115519046

@ktoso
Fix cut off sentence and correct Throwing discarding task group docs
62ffc9f 
We cut off a sentence, this corrects that issue.

resolves rdar://115519046
@ktoso ktoso requested a review from kavon as a code owner September 27, 2023 03:49
@ktoso ktoso requested a review from amartini51 September 27, 2023 03:50
@ktoso
Copy link
Contributor Author

ktoso commented Sep 27, 2023

@swift-ci please smoke test

@ktoso ktoso requested a review from FranzBusch September 27, 2023 03:51
@ktoso ktoso changed the title Fix cut off sentence and correct Throwing discarding task group docs [docs] Fix cut off sentence and correct Throwing discarding task group docs Sep 27, 2023
amartini51
amartini51 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@amartini51 amartini51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some minor wording fixes — looks good, thanks!

@amartini51
Copy link
Member

@swift-ci please smoke test

@amartini51 amartini51 mentioned this pull request Sep 27, 2023
Merged
@ktoso
Copy link
Contributor Author

ktoso commented Sep 27, 2023

Thanks Alex!

@ktoso ktoso merged commit 5ced53e into main Sep 29, 2023
@ktoso ktoso deleted the ktoso-patch-15 branch September 29, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranzBusch FranzBusch FranzBusch approved these changes

@amartini51 amartini51 amartini51 approved these changes

@kavon kavon Awaiting requested review from kavon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktoso @amartini51 @FranzBusch