[5.10][build] Move libdispatch earlier in the build so it can be used by the compiler validation suite #68640
Conversation
… always have a fresh swift-dispatch when running swift tests. In the fullness of time, we want to split the full build-script-impl pipeline so that we can begin moving library like products (libdispatch, foundation) from build-script-impl into build-script. We are not there yet since some of swift's concurrency tests have a dependency on swift dispatch being built. This breaks the build and we need to extract those tests into a separate product. But for now, this makes sense to repair the build. rdar://89046735
…g/swift-corelibs-libdispatch#785 This allows the tests that use libdispatch to find its modulemap, plus add the libdispatch compilation flags to one test that was missing them and fix one async test on linux.
…uilt before the compiler tests are run This reverts 0132841 but moves libdispatch into the earlier pipeline, so that it alone is built before the compiler validation suite is run.
|
@bnbarham, please run the CI on this. |
|
@swift-ci please test |
|
@gottesmm, should I try to enable these for the 5.9 branch also? |
There should be very few changes going to 5.9 at this point, so probably not worth it in my mind. |
@bnbarham, this changes zero behavior in the toolchain though, only slightly modifying the build order and some tests to enable several tests on the CI again. That's why I thought it might be worth it for 5.9 too, as it might catch 5.9 regressions better by having several dozen more tests run. |
|
Pinging @tbkka, ready for review. |
|
Ping @DougGregor, tiny pull that re-enables several tests on the linux CI. |
|
Ping @bnbarham, can you review and merge? I didn't know you could get pulls into 5.10. |
Cherrypick of #65829 and #68565
Explanation: The libdispatch and several concurrency tests in the validation suite were inadvertently disabled a couple years ago. This enables them again by making sure the target libdispatch is built first and using the new
dispatch-vfs-overlay.yamlit now generates.Scope: Enabling compiler tests again
Issue: #53973
Risk: negative, as it is only testing more code, thus lowering risk
Testing: Passes all CI on trunk for the last couple days, and I've been doing this manually on Android for years without a problem.
Reviewer: @gottesmm