[SR-11568] libdispatch build reorganization inadvertently disabled tsan/libdispatch tests on linux CI

[finagolfin]

Previous ID	SR-11568
Radar	None
Original Reporter	@buttaface
Type	Task
Status	Reopened
Resolution

Additional Detail from JIRA

Votes	0
Component/s	Project Infrastructure
Labels	Task
Assignee	@yln
Priority	Medium

md5: b72328092c42d46829347587214cb38a

Issue Description:

Julian Lettner enabled several of these tests for linux in May, but they depend on libdispatch.so and other files being built in a specific location. A libdispatch pull for Windows a month ago moved some of those libraries around and disabled all these tests, likely by mistake.

I reported this a couple weeks ago as a comment on that libdispatch pull but got no response, so I'm filing it here, so someone gets those tests enabled again.

Also, it would be worthwhile for the CI to report when a pull disables several tests like this, rather than only reporting failed tests, so this doesn't keep happening.

[belkadan]

cc @yln

[yln]

#27940

[finagolfin]

This broke again, probably because the build-script recently reordered the Swift compiler validation suite to run before libdispatch is built. I work around this on Android by running build-script twice, once with `--libdispatch` to build it first and then a second time to run the test suite.

@gottesmm, how should we get these tests running on the linux CI again?

[yln]

Fixed by Eric in #41135

[yln]

This issue was meant to track tests on Linux CI that are not running (`REQUIRES: libdispatch`).

Eric fixed the completely separate `Swift - TSAN - libdispatch` config:
https://ci.swift.org/view/Dashboard/job/oss-swift-tsan-libdispatch-linux-ubuntu-18_04/

[finagolfin]

@yln, I checked and these still aren't being run on the linux CI. I think simply reordering the build to make sure libdispatch is built first should fix it, should I look into it?

[yln]

@gottesmm is addressing this here: #65829