Sema: consolidate diagnostics about package modifier outside of a package
#68639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show the same error for both decls and imports when using the package access level and no package name is set. Also brings up this check to run once on decls and avoid repeated diagnostics.
|
@swift-ci Please smoke test |
xymus
changed the title
package modifier outside of a packagepackage modifier outside of a package
elsh
reviewed
Sep 19, 2023
| @@ -3,11 +3,11 @@ | |||
| // Package name should not be empty | |||
| // RUN: not %target-swift-frontend -typecheck %s -package-name "" 2>&1 | %FileCheck %s -check-prefix CHECK-EMPTY | |||
| // CHECK-EMPTY: error: package-name is empty | |||
| // CHECK-EMPTY: error: 'log' has a package access level but no -package-name was specified: {{.*}}.swift | |||
| // CHECK-EMPTY: error: the package access level requires a package name; set it with the compiler flag -package-name | |||
There was a problem hiding this comment.
Can we still pass the symbol name here? I usually find it helpful esp when there are multiple errors with the same diags.
There was a problem hiding this comment.
The tests don't show this but the diagnostics points to the attribute. Since the solution is to change a project setting I thought it would be enough. I can special case the check for a value decl if you prefer for us to keep the decl name.
There was a problem hiding this comment.
It's a nice to have, but not a strict requirement. I'm ok with adding it in the future if necessary.
There was a problem hiding this comment.
I added it back for ValueDecls.
elsh
approved these changes
Sep 19, 2023
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the same error for both decls and imports when using the package access level and no package name is set. Also brings up this check to run once on decls and avoid repeated diagnostics.