Skip to content

Move regex literal parsing logic from SwiftCompilerSources to ASTGen #68401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions SwiftCompilerSources/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -241,15 +241,9 @@ else()
#include \"Basic/BasicBridging.h\"
#include \"Basic/SourceLoc.h\"

#include \"AST/ASTBridging.h\"
#include \"AST/DiagnosticEngine.h\"
#include \"AST/DiagnosticConsumer.h\"

#include \"SIL/SILBridging.h\"

#include \"SILOptimizer/OptimizerBridging.h\"

#include \"Parse/RegexParserBridging.h\"
")
add_custom_command(
OUTPUT "${CMAKE_CURRENT_BINARY_DIR}/HeaderDependencies.cpp"
Expand Down
21 changes: 2 additions & 19 deletions SwiftCompilerSources/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -48,39 +48,22 @@ let package = Package(
.library(
name: "swiftCompilerModules",
type: .static,
targets: ["Basic", "AST", "Parse", "SIL", "Optimizer", "_CompilerRegexParser"]),
targets: ["Basic", "SIL", "Optimizer"]),
],
dependencies: [
],
// Note that targets and their dependencies must align with
// 'SwiftCompilerSources/Sources/CMakeLists.txt'
targets: [
.compilerModuleTarget(
name: "_CompilerRegexParser",
dependencies: [],
path: "_RegexParser_Sources",
swiftSettings: [
// Workaround until `_CompilerRegexParser` is imported as implementation-only
// by `_StringProcessing`.
.unsafeFlags([
"-Xfrontend",
"-disable-implicit-string-processing-module-import"
])]),
.compilerModuleTarget(
name: "Basic",
dependencies: []),
.compilerModuleTarget(
name: "AST",
dependencies: ["Basic"]),
.compilerModuleTarget(
name: "Parse",
dependencies: ["Basic", "AST", "_CompilerRegexParser"]),
.compilerModuleTarget(
name: "SIL",
dependencies: ["Basic"]),
.compilerModuleTarget(
name: "Optimizer",
dependencies: ["Basic", "SIL", "Parse"]),
dependencies: ["Basic", "SIL"]),
],
cxxLanguageStandard: .cxx17
)
14 changes: 0 additions & 14 deletions SwiftCompilerSources/Sources/AST/CMakeLists.txt

This file was deleted.

122 changes: 0 additions & 122 deletions SwiftCompilerSources/Sources/AST/DiagnosticEngine.swift

This file was deleted.

5 changes: 0 additions & 5 deletions SwiftCompilerSources/Sources/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,6 @@

# NOTE: Subdirectories must be added in dependency order.

if(SWIFT_BUILD_REGEX_PARSER_IN_COMPILER)
add_subdirectory(_RegexParser)
endif()
add_subdirectory(Basic)
add_subdirectory(AST)
add_subdirectory(Parse)
add_subdirectory(SIL)
add_subdirectory(Optimizer)
2 changes: 1 addition & 1 deletion SwiftCompilerSources/Sources/Optimizer/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
# See http://swift.org/CONTRIBUTORS.txt for Swift project authors

set(dependencies)
list(APPEND dependencies Basic SIL Parse)
list(APPEND dependencies Basic SIL)

add_swift_compiler_module(Optimizer DEPENDS ${dependencies})

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,12 @@

import SIL
import OptimizerBridging
import Parse

@_cdecl("initializeSwiftModules")
public func initializeSwiftModules() {
@_cdecl("initializeSwiftSILModules")
public func initializeSwiftSILModules() {
registerSILClasses()
registerSwiftAnalyses()
registerSwiftPasses()
initializeSwiftParseModules()
registerSILTests()
}

Expand Down
19 changes: 0 additions & 19 deletions SwiftCompilerSources/Sources/Parse/CMakeLists.txt

This file was deleted.

16 changes: 0 additions & 16 deletions SwiftCompilerSources/Sources/Parse/Parse.swift

This file was deleted.

20 changes: 0 additions & 20 deletions SwiftCompilerSources/Sources/_RegexParser/CMakeLists.txt

This file was deleted.

1 change: 0 additions & 1 deletion SwiftCompilerSources/_RegexParser_Sources

This file was deleted.

6 changes: 2 additions & 4 deletions SwiftCompilerSources/stubs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,8 @@

extern "C" {

void initializeSwiftModules();
void initializeSwiftParseModules();
void initializeSwiftSILModules();

}

void initializeSwiftModules() {}
void initializeSwiftParseModules() {}
void initializeSwiftSILModules() {}
8 changes: 0 additions & 8 deletions include/module.modulemap
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,7 @@ module CBasicBridging {

module ASTBridging {
header "swift/AST/AnyFunctionRef.h"
header "swift/AST/ASTBridging.h"
header "swift/AST/Builtins.h"
header "swift/AST/DiagnosticEngine.h"
header "swift/AST/DiagnosticConsumer.h"
header "swift/AST/ForeignAsyncConvention.h"
header "swift/AST/ForeignErrorConvention.h"
header "swift/AST/SubstitutionMap.h"
Expand All @@ -41,8 +38,3 @@ module OptimizerBridging {
header "swift/SILOptimizer/OptimizerBridging.h"
export *
}

module _RegexParserBridging {
header "swift/Parse/RegexParserBridging.h"
export *
}
56 changes: 0 additions & 56 deletions include/swift/AST/ASTBridging.h

This file was deleted.

Loading