[cxx-interop] Introduce APINotes file for C++ stdlib #68118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! |
hyp
approved these changes
Aug 24, 2023
compnerd
reviewed
Aug 25, 2023
egorzhdan
added a commit
to swiftlang/swift-installer-scripts
that referenced
this pull request
Aug 25, 2023
See swiftlang/swift#68118. rdar://107572302
|
@compnerd yeap, just put up a PR: swiftlang/swift-installer-scripts#230 |
|
@swift-ci please smoke test |
|
Please test with following PRs: swiftlang/swift-installer-scripts#230 @swift-ci please build toolchain windows |
egorzhdan
force-pushed
the
egorzhdan/cxxstdlib-apinotes
branch
from
8f16a1e to
d386e81
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxxstdlib-apinotes
branch
from
d386e81 to
3deacfd
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
This adds an `std.apinotes` file that is installed into `lib/swift/apinotes` along with existing Darwin apinotes. This new file is installed on all platforms. It replaces a few special cases in the compiler for `cmath` and `cstring` functions. This does not require the upcoming APINotes support for namespaces, however, this does require swiftlang/llvm-project#7309. rdar://107572302
egorzhdan
force-pushed
the
egorzhdan/cxxstdlib-apinotes
branch
from
3deacfd to
9b7dbf2
Compare
|
@swift-ci please smoke test |
|
Please test with following PRs: swiftlang/swift-installer-scripts#230 @swift-ci please build toolchain windows |
1 similar comment
|
Please test with following PRs: swiftlang/swift-installer-scripts#230 @swift-ci please build toolchain windows |
egorzhdan
added a commit
to swiftlang/swift-installer-scripts
that referenced
this pull request
Aug 30, 2023
See swiftlang/swift#68118. rdar://107572302
|
Please test with following PRs: swiftlang/swift-installer-scripts#230 @swift-ci please build toolchain windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
std.apinotesfile that is installed intolib/swift/apinotesalong with existing Darwin apinotes. This new file is installed on all platforms. It replaces a few special cases in the compiler forcmathandcstringfunctions.This does not require the upcoming APINotes support for namespaces, however, this does require swiftlang/llvm-project#7309.
rdar://107572302