[5.9] Availability checking for uses of macros #67751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
DougGregor
commented
Aug 4, 2023
DougGregor
commented
- Explanation: Perform availability checking for uses of macros, to ensure that we reject (e.g.) an attempt to use a macro with availability that's newer than the current availability context.
- Scope: Narrow. Only affects uses of macros, to ensure that they respect availability.
- Risk: Low. Only affects macro uses.
- Original pull request: [Macros] Emit deprecation warnings for uses of macros. #67698, Expand type refinement contexts to encompass attributes #67732, Ensure that macro overloading via availability works #67748
- Issue: rdar://113138432&113047811
|
@swift-ci please test |
|
Thanks for pulling this into 5.9! |
Fixes rdar://113138432. (cherry picked from commit 0a1fbe7)
(cherry picked from commit c3af8cb)
This was already fixed by a previous change (swiftlang#67698), but this introduces a test case to ensure that we don't regress rdar://113047811.
(cherry picked from commit 0e80b4e)
DougGregor
force-pushed
the
macro-reference-availability-5.9
branch
from
7927fb2 to
75078e3
Compare
|
@swift-ci please test |
hborla
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.