Skip to content

[Concurrency] Fix crash when actor is dynamically subclassed. #67681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented Aug 2, 2023

Dynamic subclasses have a NULL type descriptor. Make sure isDefaultActorClass doesn't try to dereference that NULL descriptor.

rdar://112223265

@mikeash mikeash requested review from ktoso and kavon as code owners August 2, 2023 20:18
@mikeash
Copy link
Contributor Author

mikeash commented Aug 2, 2023

@swift-ci please test

Dynamic subclasses have a NULL type descriptor. Make sure isDefaultActorClass doesn't try to dereference that NULL descriptor.

rdar://112223265
@mikeash mikeash force-pushed the fix-actor-dynamic-subclassing branch from e5303b8 to 9f9929a Compare August 2, 2023 23:05
@mikeash
Copy link
Contributor Author

mikeash commented Aug 2, 2023

@swift-ci please test

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa objc can do some nasty stuff huh, LGTM

@mikeash
Copy link
Contributor Author

mikeash commented Aug 3, 2023

@swift-ci please test

@mikeash
Copy link
Contributor Author

mikeash commented Aug 3, 2023

@swift-ci please test windows platform

@mikeash mikeash merged commit f674e56 into swiftlang:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants