Skip to content

Ensure we can fold apply of a differentiable_function_inst. #65605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2023
Merged

Ensure we can fold apply of a differentiable_function_inst. #65605

merged 1 commit into from
Sep 5, 2023

Conversation

asl
Copy link
Contributor

@asl asl commented May 3, 2023 •
edited
Loading

Also fix one small potential issue while there.

Fixes #65489
Fixes #67992

@asl
Copy link
Contributor Author

asl commented May 3, 2023

@swift-ci please test

@asl asl requested a review from eeckstein May 3, 2023 00:15
@asl
Copy link
Contributor Author

asl commented May 3, 2023

Tagging @BradLarson @rxwei @dan-zheng

@asl asl mentioned this pull request Sep 1, 2023
Closed
@asl
Ensure we can fold apply of a differentiable_function_inst. Also fi…
b646d49 
…xes one small potential issue while there.

Fixes #65489 #67992
@asl asl requested a review from meg-gupta September 1, 2023 19:43
@asl
Copy link
Contributor Author

asl commented Sep 1, 2023

@swift-ci please test

@asl asl merged commit 118fd86 into main Sep 5, 2023
@asl asl deleted the 65489-fix branch September 5, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxwei rxwei rxwei approved these changes

@eeckstein eeckstein Awaiting requested review from eeckstein eeckstein is a code owner

@meg-gupta meg-gupta Awaiting requested review from meg-gupta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix SILCombine of convert_escape_to_no_escape ( differentiable_function for OSSA apply of differentiable_function is not optimized
2 participants
@asl @rxwei