Skip to content

🍒[cxx-interop] Add operators for comparing and concatenating std::strings #64725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

egorzhdan
Copy link
Contributor

The original C++ operators are not currently imported into Swift because they are defined as a non-member templated functions.

This change adds the operators as Swift extension functions. This also adds an Equatable conformance for std::string.

rdar://107017882
(cherry picked from commit 62cb187)

…ing`s

The original C++ operators are not currently imported into Swift because they are defined as a non-member templated functions.

This change adds the operators as Swift extension functions. This also adds an `Equatable` conformance for `std::string`.

rdar://107017882
(cherry picked from commit 62cb187)
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Mar 29, 2023
@egorzhdan egorzhdan requested a review from a team as a code owner March 29, 2023 16:49
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@egorzhdan egorzhdan changed the title [cxx-interop] Add operators for comparing and concatenating std::strings 🍒[cxx-interop] Add operators for comparing and concatenating std::strings Mar 29, 2023
@egorzhdan egorzhdan merged commit 0794b70 into release/5.9 Mar 30, 2023
@egorzhdan egorzhdan deleted the egorzhdan/5.9-std-string-concat branch March 30, 2023 16:38
@AnthonyLatsis AnthonyLatsis added the 🍒 release cherry pick Flag: Release branch cherry picks label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++ 🍒 release cherry pick Flag: Release branch cherry picks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants