Skip to content

[NFC] Readability for isRedundantMoveValue. #64483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nate-chandler
Copy link
Contributor

Improved comments and flattened conditions.

Follow-up to #64448 .

@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macOS platform

2 similar comments
@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macOS platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please clean test macOS platform

Copy link
Contributor

@atrick atrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Great comments!

@nate-chandler nate-chandler force-pushed the nfc/20230320/1/redundant-move branch from ebb6a4b to 2d4c05e Compare March 21, 2023 14:21
Improved comments and flattened conditions.
@nate-chandler nate-chandler force-pushed the nfc/20230320/1/redundant-move branch from 2d4c05e to b7f447d Compare March 21, 2023 14:57
@nate-chandler
Copy link
Contributor Author

@swift-ci please test macOS platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please test linux platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please test windows platform

@nate-chandler nate-chandler merged commit 1482108 into swiftlang:main Mar 21, 2023
@nate-chandler nate-chandler deleted the nfc/20230320/1/redundant-move branch March 21, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants