[Runtime] Fix subscript key path printing when arguments can't be resolved. #63305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
mikeash
force-pushed
the
print-keypath-dependent-generic-type
branch
from
f858eed to
19d3a32
Compare
|
@swift-ci please test |
|
@swift-ci please test linux platform |
al45tair
reviewed
Feb 2, 2023
| if (i < argumentTypeNames.size()) | ||
| return argumentTypeNames[i]; | ||
| return std::string("<unknown>"); | ||
| }; |
al45tair
approved these changes
Feb 2, 2023
|
@swift-ci please test linux platform |
…olved. If there's a mismatch between the arguments we match and the arguments we actually have, we can end up indexing off the end of the argumentTypeNames vector. This can happen when an argument has a dependent generic type. Add a bounds check and print <unknown> when we're out of bounds to avoid crashing. For correctness, we should match generic dependent types and add them to the arguments array, but we'll fix the crashes first. rdar://104438524
mikeash
force-pushed
the
print-keypath-dependent-generic-type
branch
from
19d3a32 to
91dcf8d
Compare
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's a mismatch between the arguments we match and the arguments we actually have, we can end up indexing off the end of the argumentTypeNames vector. This can happen when an argument has a dependent generic type. Add a bounds check and print when we're out of bounds to avoid crashing.
For correctness, we should match generic dependent types and add them to the arguments array, but we'll fix the crashes first.
rdar://104438524
Fixes #64865