Make TypeRefBuilder::getFieldTypeInfo iterate over images in a smarter manner #59895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when looking for field descriptors we parse the reflection metadata in whatever order it was registered. This patch implements a heuristic where we try to match a new optional Name field with the module name of the type's field descriptor we're looking for. rdar://87889973 (cherry picked from commit 65a9e7d)
|
@swift-ci test |
nkcsgexi
approved these changes
Jul 6, 2022
|
Thanks @nkcsgexi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Currently, whenever we're asked to retrieve a particular
FieldDescriptorfor aTypeRef, we naively parse all theReflectionInfosin the order they were registered (caching everything) until we find the one we're looking for. This can be very costly for the debugger, as we may be reading memory from a remote target. This patch introduces a heuristic to prioritize this search by processing firstReflectionInfoswhere theFieldDescriptorwe're looking for is likely to be. If the heuristic fails, we fallback to the old behavior. In profiling debugging large apps, this has significant impact on the time to stop on the first breakpoint.Risk: Low. If the heuristic fails we fall back to the old behavior.
Testing: Swift reflection tests plus all lldb tests that use frame variable.
Original PR: #59802 plus
Typeref.cppchanges from #59262Issue: rdar://87889973