[CodeCompletion] Don't generate constraints for parts of a result builder unrelated to the code completion token #42296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lder unrelated to the code completion token
|
@swift-ci Please SourceKit stress test |
ahoppen
changed the title
|
@swift-ci Please smoke test |
xedin
reviewed
Apr 13, 2022
|
@ahoppen I think you could skip statements entirely (just |
|
Actually no, statements are added to the buildBlock so they’s need a placeholder |
|
Superseded by #59992 |
ahoppen
deleted the
pr/no-constraints-for-unused-result-builder-constructs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically resolves all performance-related problems in
TurnipsView.swiftof the ACHNBrowserUI project in the stress tester, improving average code completion duration from 4 billion instructions to 1 billion instruction in that file.rdar://90769979 [SR-16056]