[stdlib] Fix some Clock issues #41485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntations These used to set the clock id incorrectly, leading to zero results. Fix that and also make the underlying entry point abort if it gets an invalid ID, preventing this from reoccurring.
Having a direct initializer in the ABI is critically important — otherwise we wouldn’t be able to add back deployable conversion initializers in the future (without going through unnecessary overhead).
`Words.Iterator.next()` used to call `Int128(truncatingIfNeeded:)`, which in turn iterates over words, leading to an infinite recursion. Implement half-width multiplication from scratch instead of masking off the full width results.
|
These fixes are enough to have the benchmark suite adopt these APIs; however, that goes in a separate followup PR as we may not be able to land that change without implementing adding additional code to backport these APIs to earlier releases. Another issue we will need to fix is the lack of regression tests for these APIs. |
|
@swift-ci test |
|
I am still working on regression tests and such for those types. Hopefully will have something ready next week. Overall the changes look reasonable to me. |
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.nowand.minimumResolutionimplementations. These used to set the clock id incorrectly, leading to zero results. Fix that and also make the underlying entry point abort if it gets an invalid ID, preventing this from reoccurring.Duration: add a (non-public) initializer that takes low/high components. Having a direct initializer in the ABI is critically important — otherwise we wouldn’t be able to add back deployable conversion initializers in the future (without going through unnecessary overhead).Int128: FixWords.Words.Iterator.next()used to callInt128(truncatingIfNeeded:), which in turn iterates over words, leading to an infinite recursion.Int128: Implement half-width multiplication from scratch instead of masking off the full width results.