Skip to content

Invoke correct CMake when building tsan libdispatch #41135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Feb 1, 2022

This should address a build failure on TSAN - libdispatch Linux bots

Addresses rdar://88339546

This should address a build failure on TSAN - libdispatch Linux bots

Addresses rdar://88339546
@edymtt
Copy link
Contributor Author

edymtt commented Feb 1, 2022

preset=buildbot_incremental_linux,tsan-libdispatch-test
@swift-ci Please test with preset Linux Platform

@edymtt
Copy link
Contributor Author

edymtt commented Feb 1, 2022

@swift-ci please python lint

@edymtt
Copy link
Contributor Author

edymtt commented Feb 1, 2022

preset=buildbot_incremental_linux,tsan-libdispatch-test
@swift-ci Please test with preset Linux Platform

@finagolfin
Copy link
Member

Btw, the CI no longer runs the libdispatch or tsan tests because of a pull six months ago, reported in SR-11568.

@edymtt
Copy link
Contributor Author

edymtt commented Feb 3, 2022

Thanks for the pointers, I was not fully aware for the context.

For now I will focus on the immediate failure, so to be in a position in which we can tackle the deeper issue.

@edymtt
Copy link
Contributor Author

edymtt commented Feb 3, 2022

@swift-ci please python lint

@edymtt
Copy link
Contributor Author

edymtt commented Feb 3, 2022

preset=buildbot_incremental_linux,tsan-libdispatch-test
@swift-ci Please test with preset Linux Platform

@edymtt
Copy link
Contributor Author

edymtt commented Feb 3, 2022

@swift-ci Please smoke test and merge

@swift-ci swift-ci merged commit 983cf2c into swiftlang:main Feb 4, 2022
edymtt added a commit to edymtt/swift that referenced this pull request Feb 4, 2022
This addresses a build failure on TSAN - libdispatch Linux bots

Cherry-pick of swiftlang#41135

Addresses rdar://88339546
@edymtt edymtt deleted the build-tsan-libdispatch-with-correct-cmake branch February 4, 2022 15:32
edymtt added a commit that referenced this pull request Feb 4, 2022
…41203)

This addresses a build failure on TSAN - libdispatch Linux bots

Cherry-pick of #41135

Addresses rdar://88339546
@yln
Copy link
Contributor

yln commented Feb 14, 2022

Btw, the CI no longer runs the libdispatch or tsan tests because of a pull six months ago, reported in SR-11568.

I've confirmed that the config is up and running again:
https://ci.swift.org/view/Dashboard/job/oss-swift-tsan-libdispatch-linux-ubuntu-18_04/

Note that we are only running the intersection of TSan/compiler-rt + Linux + libdispatch (no Swift) tests. This config is meant to protect agains issues that would only show with the version of libdispatch used on Linux (compiled from source), but not with the system-provided one (Apple platforms). We have end-to-end "TSan for Swift" tests that run as part of the the normal Swift regression suite (including Linux).

Testing Time: 3.25s
  Excluded: 398
  Passed  :  37

So since there is no Swift testing, we can ignore the few build-script-impl at the bottom that do nothing.

@finagolfin
Copy link
Member

Just to be clear, I'm talking about the normal linux CI that runs 15k tests from the compiler validation suite on every pull, eg all tsan tests are now disabled for a recent CI run because they depend on libdispatch.

I was unaware of this separate swift-tsan-libdispatch-linux-ubuntu-18_04 CI bot that @yln now points out, that apparently runs 30-40 tests a couple times per day? If it's been decided that's enough and there's no need to run these libdispatch and tsan tests for every pull, I'll close that bug report I reopened.

@yln
Copy link
Contributor

yln commented Feb 16, 2022

Thanks for clarifying this; I was confused. Both should be running!
So basically we are not running any tests with REQUIRES: libdispatch on Linux CI; that's not just TSan tests and should be fixed.
@edymtt: can you help with repairing this again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants