-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Invoke correct CMake when building tsan libdispatch #41135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoke correct CMake when building tsan libdispatch #41135
Conversation
This should address a build failure on TSAN - libdispatch Linux bots Addresses rdar://88339546
preset=buildbot_incremental_linux,tsan-libdispatch-test |
@swift-ci please python lint |
preset=buildbot_incremental_linux,tsan-libdispatch-test |
Btw, the CI no longer runs the libdispatch or tsan tests because of a pull six months ago, reported in SR-11568. |
Thanks for the pointers, I was not fully aware for the context. For now I will focus on the immediate failure, so to be in a position in which we can tackle the deeper issue. |
@swift-ci please python lint |
preset=buildbot_incremental_linux,tsan-libdispatch-test |
@swift-ci Please smoke test and merge |
This addresses a build failure on TSAN - libdispatch Linux bots Cherry-pick of swiftlang#41135 Addresses rdar://88339546
I've confirmed that the config is up and running again: Note that we are only running the intersection of
So since there is no Swift testing, we can ignore the few |
Just to be clear, I'm talking about the normal linux CI that runs 15k tests from the compiler validation suite on every pull, eg all tsan tests are now disabled for a recent CI run because they depend on libdispatch. I was unaware of this separate |
Thanks for clarifying this; I was confused. Both should be running! |
This should address a build failure on TSAN - libdispatch Linux bots
Addresses rdar://88339546