Skip to content

compare Set and Dictionary by address for equality #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions stdlib/public/core/HashedCollections.swift.gyb
Original file line number Diff line number Diff line change
Expand Up @@ -678,8 +678,10 @@ public func == <Element : Hashable>(lhs: Set<Element>, rhs: Set<Element>) -> Boo
case (.Native(let lhsNativeOwner), .Native(let rhsNativeOwner)):
let lhsNative = lhsNativeOwner.nativeStorage
let rhsNative = rhsNativeOwner.nativeStorage
// FIXME(performance): early exit if lhs and rhs reference the same
// storage?

if lhsNativeOwner === rhsNativeOwner {
return true
}

if lhsNative.count != rhsNative.count {
return false
Expand Down Expand Up @@ -1184,8 +1186,10 @@ public func == <Key : Equatable, Value : Equatable>(
case (.Native(let lhsNativeOwner), .Native(let rhsNativeOwner)):
let lhsNative = lhsNativeOwner.nativeStorage
let rhsNative = rhsNativeOwner.nativeStorage
// FIXME(performance): early exit if lhs and rhs reference the same
// storage?

if lhsNativeOwner === rhsNativeOwner {
return true
}

if lhsNative.count != rhsNative.count {
return false
Expand Down