compare Set and Dictionary by address for equality #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // FIXME(performance): early exit if lhs and rhs reference the same | ||
| // storage? | ||
|
|
||
| if unsafeAddressOf(lhsNativeOwner) == unsafeAddressOf(rhsNativeOwner) { |
There was a problem hiding this comment.
I don't think that's right, this code would compare addresses of the let bindings.
Does === work?
|
@dduan Can you take a look at |
|
Hi, @gribozavr, both are covered in debug build. cc @nadavrot |
|
@gribozavr Switched to |
as noted in the comment, the native storage version of Set and Dictionary can be considered equal if their Owner object have the same address. This should speed up == by quite a bit in those cases. use === for equality of HashedCollection owner
dduan
force-pushed
the
hashed_collection_equality_by_address
branch
from
cfeab2b to
9c28ff0
Compare
|
@gribozavr @dduan No concerns. Thanks for doing the work. |
|
@gribozavr @nadavrot squashed. Thank you :) |
gribozavr
added a commit
that referenced
this pull request
Dec 10, 2015
compare Set and Dictionary by address for equality
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
queue: clean up a covered switch
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
[perf_test] Update performance `smoke test` project configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as noted in the comment, the native storage version of Set and Dictionary can
be considered equal if their Owner object have the same address. This should
speed up == by quite a bit in those cases.