[cxx-interop] Correctly import static function templates. #35548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is required for #35085, just fyi. |
gribozavr
approved these changes
Jan 25, 2021
Contributor
Author
|
Just FYI: this is going to fail now that I updated test/Interop/Cxx/templates/member-templates-silgen.swift in #35416. I'll fix the tests in #35547 then rebase + land. Thanks @gribozavr! |
zoecarver
force-pushed
the
cxx/fix-static-function-templates
branch
from
0dbee1d to
952426f
Compare
Handle static members the same way we handle other member function templates. Also, set the "static"ness of the new (specialized) function decl.
zoecarver
force-pushed
the
cxx/fix-static-function-templates
branch
from
952426f to
02b5118
Compare
Contributor
Author
|
@swift-ci please smoke test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle static members the same way we handle other member function templates. Also, set the "static"ness of the new (specialized) function decl.