Skip to content

[ownership] Move ownership lowering past SROA. #34134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

I already updated SROA for this and we already have tests/etc. We have just been
waiting on some other passes to be moved afterwards.

I already updated SROA for this and we already have tests/etc. We have just been
waiting on some other passes to be moved afterwards.
@gottesmm gottesmm requested a review from meg-gupta September 30, 2020 21:09
@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm
Copy link
Contributor Author

@swift-ci benchmark

@gottesmm
Copy link
Contributor Author

Windows failure is I believe an lldb failure. Not this.

@swift-ci
Copy link
Contributor

Performance: -O

Code size: -O

Performance: -Osize

Improvement OLD NEW DELTA RATIO
FlattenListFlatMap 6064 3944 -35.0% 1.54x (?)
FlattenListLoop 2060 1628 -21.0% 1.27x (?)
DictionaryKeysContainsNative 31 28 -9.7% 1.11x (?)

Code size: -Osize

Performance: -Onone

Regression OLD NEW DELTA RATIO
StringToDataMedium 7100 7850 +10.6% 0.90x (?)

Code size: -swiftlibs

How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@gottesmm gottesmm merged commit 8bc6f83 into swiftlang:main Oct 1, 2020
@gottesmm gottesmm deleted the pr-d16ec3e1fe4adcc9f0993211cdbc57fd7024a93e branch October 1, 2020 00:48
Copy link
Contributor

@meg-gupta meg-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants