More ASTScope cleanups #34076
More ASTScope cleanups #34076
Conversation
If we're searching for a declaration with a given name, the name should be entirely encapsulated inside the DeclConsumer. Otherwise, there might not be a specific name at all, if we're performing code completion for example (once LookupVisibleDecls starts to use ASTScope, anyway).
|
@swift-ci Please smoke test |
davidungar
left a comment
davidungar
left a comment
There was a problem hiding this comment.
All this code was there originally to help me debug these tough bugs that happened when the AST changed out from under ASTScopes.
I didn't quite remember this code when we spoke about it earlier today.
I don't mind deleting it, but it would sure be great if we could add a flag somewhere that would prevent the creation of any new explicit DECLs after the first ASTScope lookup. Is there any possibility of that?
|
I’ll think about that along with the other assertions I promised you I would add. |
Thanks. It you figure out a good way do it, it would be so cool to just replace the other assertions. No need to add most of them if we can do that. |
2 participants
No description provided.