[ConstraintSystem] Don't update the work list when merging type variables in addJoinConstraint #33401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bles in addJoinConstraint.
|
@swift-ci please smoke test |
|
Should we remove the default argument for |
|
@hamishknight Yeah, I think that's a good idea. That certainly would have prevented me from making this mistake 😅 |
ConstraintSystem::mergeEquivalenceClasses. Most callers don't use the default, and it's important to consider the value of this argument for each call to mergeEquivalenceClasses.
|
@swift-ci please smoke test |
xedin
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing
/*updateWorkList=*/falseargument turnsmergeEquivalenceClassesinto a very expensive operation because it needs to gather constraints in order to update the worklist. It isn't necessary to activate these constraints anyway because theconforms to ExpressibleBy*constraints will be unsolvable at this point.Resolves: rdar://problem/66807959