[SymbolGraph] Check Loc validity before extracting text #33370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hit this crash while walking an `import protocol ...` declaration. Check loc validity before calling `SourceManager::extractText`: there is an assertion at the beginning of this function. rdar://65258208
|
@nathawes It looks like you changed this code not too long ago; can you check this please? I hit this while walking to an |
nathawes
approved these changes
Aug 7, 2020
|
@swift-ci Please smoke test |
|
Thank you! |
bitjammer
deleted the
acgarland/rdar-65258208-crash-invalid-loc-extracttext
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit this crash while walking an
import protocol ...declaration.Check loc validity before calling
SourceManager::extractText:there is an assertion at the beginning of this function.
rdar://65258208