[5.3][Sema] Warn on exporting implementation-only imported types in SPI #33213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Downgrade to a warning the diagnostics on the use of an implemenetation-only type in SPI to allow support for -experimental-spi-imports. rdar://66336527
|
@swift-ci Please test |
nkcsgexi
approved these changes
Jul 30, 2020
|
@swift-ci Please nominate |
tkremenek
approved these changes
Jul 31, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes type-checking work for #32902. Bringing back the diagnostic on exporting implementation-only imported types in SPI as a warning. This check was previously reverted from 5.3, and now it can be valid when relying solely on swiftmodule files or when using
-experimental-spi-imports. This is part of a staged transition to a long term language feature of imports as SPI.