[5.3][ModuleInterface] Print some implementation-only imports in the private interface #32902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@swift-ci Please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
beccadax
approved these changes
Jul 15, 2020
A swiftmodule file that has implementation-only imports and SPIs relying on the imports works because of deserialization recovery. A client can access the SPIs only if the client also imported the module behind the related implementation-only import. If the module isn't imported by the client, the SPIs fail to deserialize and are not visible. We don't want to rely on deserialization recovery for this in the long term either. |
…te interface Print implementation-only imports in the private textual interface only if also importing SPI. This allows to export types from implementation-only imports in SPI and brings the private textual interfaces in line with the binary interfaces. This is a temporary solution as we need to better design the language feature around this. This feature requires passing -experimental-spi-imports to the frontend that generates the private swiftinterface file.
nkcsgexi
approved these changes
Jul 15, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@swift-ci Please nominate |
tkremenek
approved these changes
Jul 17, 2020
This was referenced Jul 30, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an experimental feature to print implementation-only imports that include SPIs in the private swiftinterface, e.g.
@_implementationOnly @_spi(Private) import A. This allows projects to export types from implementation-only imports in local SPI and aligns the behavior of compiling against binary interfaces with the use of private textual interfaces.This is a temporary solution behind the frontend flag
-experimental-spi-imports.