Skip to content

[5.3] Refactor Mirror to reduce metadata allocation #32957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kylemacomber
Copy link
Contributor

@kylemacomber kylemacomber commented Jul 17, 2020

Cherry pick of #32041

rdar://problem/65726982

- Refactor Mirror.descendents

- Add _Either sequence

- Create custom reflected children type

- Switch Mirror to use _Either
@kylemacomber kylemacomber requested a review from a team as a code owner July 17, 2020 19:38
@kylemacomber
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 5e1278b

@lorentey
Copy link
Member

@swift-ci test macOS platform

@airspeedswift airspeedswift merged commit a7542a5 into swiftlang:release/5.3 Jul 17, 2020
@kylemacomber kylemacomber deleted the such-lazy-children branch July 17, 2020 23:47
airspeedswift added a commit that referenced this pull request Aug 6, 2020
airspeedswift added a commit that referenced this pull request Aug 6, 2020
@AnthonyLatsis AnthonyLatsis added swift 5.3 🍒 release cherry pick Flag: Release branch cherry picks labels Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants