Sema: Fix crash on circular reference in checkContextualRequirements() #32776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to getGenericSignature() might return nullptr if we encounter a circular reference. Fixes <rdar://problem/64992293>.
Contributor
Author
|
@swift-ci Please smoke test |
| public extension Wrapper where Content == Impl<WrapperParam> { | ||
| typealias WrapperParam = SomeProtocol | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Slightly more reduced:
protocol SomeProtocol {}
struct G<T> {}
struct Wrapper<Content: SomeProtocol> {}
extension Wrapper where Content == G<Wrapper.WrapperParam> {
typealias WrapperParam = Never
}
Contributor
Author
There was a problem hiding this comment.
The original test case came from a radar. I like to keep those mostly as-is, in case they uncover more bugs in the future.
AnthonyLatsis
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to getGenericSignature() might return nullptr if we encounter
a circular reference.
Fixes rdar://problem/64992293.