Request-ify synthesis of the main function for the @main attribute #32767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CC @compnerd |
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test source compatibility |
nate-chandler
approved these changes
Jul 8, 2020
theblixguy
reviewed
Jul 8, 2020
test/SILGen/`
Outdated
Collaborator
There was a problem hiding this comment.
This file is called (`), is this expected?
Contributor
Author
There was a problem hiding this comment.
No, that's a mistake. oops
This simplifies matters if checking an attribute adds members to the nominal type or extension.
slavapestov
force-pushed
the
requestify-main-attr
branch
from
188e0d5 to
7bc5088
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test source compatibility |
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test source compatibility |
Member
|
@swift-ci please test Windows platform |
| auto &context = D->getASTContext(); | ||
|
|
||
| MainTypeAttr *attr = D->getAttrs().getAttribute<MainTypeAttr>(); | ||
| if (attr == nullptr) |
Collaborator
There was a problem hiding this comment.
Should this be an assert instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that EmittedMembersRequest is cached, we need to synthesize it when collecting all the members of the class. Use a request for this, instead of just doing it from the AttributeChecker.
Also add some SILGen tests to ensure that the main function is actually emitted; previously we didn't test for this.
This fixes the regression from #32581.