[NFC] [cxx-interop] Add SILGen tests for synthesized initializers. #32658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribozavr
reviewed
Jul 1, 2020
zoecarver
force-pushed
the
cxx/test/no-arg-const
branch
from
cc574e7 to
f485845
Compare
MForster
reviewed
Jul 2, 2020
gribozavr
reviewed
Jul 2, 2020
gribozavr
reviewed
Jul 2, 2020
zoecarver
force-pushed
the
cxx/test/no-arg-const
branch
from
f485845 to
1bfacae
Compare
Adds a basic test that the synthesized C++ constructor was generated correctly.
zoecarver
force-pushed
the
cxx/test/no-arg-const
branch
from
1bfacae to
4b14487
Compare
MForster
approved these changes
Jul 3, 2020
Contributor
Author
|
@swift-ci please smoke test and merge. |
Contributor
|
Thanks, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a basic test that the synthesized C++ constructor was generated correctly.
I think our constructor tests are currently a bit lacking. As I make more changes to how C++ constructors are created, I'll be adding more (relevant) tests with each patch. Hopefully, that and the added tests in #30630 will increase the overall coverage.
Refs #32534.