SILGen: Fix source location for the enum payload argument source #31743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should use the source location of the call site, and not the enum element declaration, otherwise we emit incorrect debug info. Fixes <rdar://problem/63067437>.
slavapestov
force-pushed
the
source-loc-enum-constructor
branch
from
28f9c30 to
23cbd7f
Compare
|
@swift-ci Please smoke test |
| return .hasPayload(argument: 123) | ||
| } | ||
|
|
||
| // CHECK-NOT: enum_debuginfo_other.swift |
There was a problem hiding this comment.
Can you add any kind of positive check, too? Otherwise this will pass even if someone symlinks swiftc to /bin/true ...
There was a problem hiding this comment.
If I'm going to be super nit-picky about the test name, technically, this is a SILLocation, and pre-debuginfo :-)
|
@swift-ci Please smoke test |
beccadax
added a commit
to beccadax/swift
that referenced
this pull request
Jul 13, 2020
Tweak this test to only look for debug info references to the filename, not *any* reference to the filename.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should use the source location of the call site, and not the enum
element declaration, otherwise we emit incorrect debug info.
Fixes rdar://problem/63067437.