[android][aarch64] Add Android to set of stable ABI testing targets. #30391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IRGen/conditional_conformances.swift was failing because Android AArch64 was taking the non ABI stable checks, but generating the ABI stable code.
|
@swift-ci please test |
compnerd
approved these changes
Mar 13, 2020
|
Just noticed this. Thanks! Disregard my message from the other thread then (catching up on my email in chronological order...) |
3405691582
added a commit
to 3405691582/swift
that referenced
this pull request
Jul 1, 2020
See swiftlang#30391, swiftlang#30296. Neither IRGen/conditional_conformances.swift nor IRGen/class_resilience.swift pass on OpenBSD unless target_mandates_stable_abi = TRUE.
3405691582
added a commit
to 3405691582/swift
that referenced
this pull request
Dec 11, 2020
See swiftlang#30391, swiftlang#30296. Neither IRGen/conditional_conformances.swift nor IRGen/class_resilience.swift pass on OpenBSD unless target_mandates_stable_abi = TRUE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRGen/conditional_conformances.swift was failing because Android AArch64
was taking the non ABI stable checks, but generating the ABI stable
code.
The problem appeared after https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android-arm64/3960/ (probably in 3961, but it is not longer available). https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android-arm64/3998/ still shows the error.