Skip to content

Fix failing IRGen arm64e tests #30296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2020
Merged

Fix failing IRGen arm64e tests #30296

merged 1 commit into from
Mar 10, 2020

Conversation

kubamracek
Copy link
Contributor

No description provided.

@kubamracek
Copy link
Contributor Author

@swift-ci smoke test

@kubamracek kubamracek force-pushed the mracek/arm64e-test-fixes branch from 2d15872 to 99d0e28 Compare March 9, 2020 21:10
@kubamracek
Copy link
Contributor Author

@swift-ci smoke test

1 similar comment
@kubamracek
Copy link
Contributor Author

@swift-ci smoke test

@kubamracek kubamracek force-pushed the mracek/arm64e-test-fixes branch from 99d0e28 to 17cfb1b Compare March 9, 2020 21:57
@kubamracek
Copy link
Contributor Author

@swift-ci smoke test

@kubamracek kubamracek force-pushed the mracek/arm64e-test-fixes branch from 17cfb1b to a305879 Compare March 10, 2020 04:03
@kubamracek
Copy link
Contributor Author

@swift-ci smoke test

1 similar comment
@kubamracek
Copy link
Contributor Author

@swift-ci smoke test

@kubamracek kubamracek force-pushed the mracek/arm64e-test-fixes branch from a305879 to 70643f6 Compare March 10, 2020 16:25
@kubamracek
Copy link
Contributor Author

@swift-ci smoke test

1 similar comment
@kubamracek
Copy link
Contributor Author

@swift-ci smoke test

@kubamracek kubamracek merged commit c728d7a into master Mar 10, 2020
@kubamracek kubamracek deleted the mracek/arm64e-test-fixes branch March 10, 2020 18:22
@drodriguez
Copy link
Contributor

@kubamracek: seems that this change, which sets linux-gnu with an stable ABI for testing, might broke the Android tests (https://ci-external.swift.org/job/oss-swift-RA-linux-ubuntu-16.04-android-arm64/3981). It seems that the code I am seeing generated might work with the stable ABI checks. Is it safe to put Android in that list of targets? (I can open the PR myself, but I want to double check that I am not doing something weird)

@kubamracek
Copy link
Contributor Author

Sorry for the late reply! The “stable ABI” applies only to platforms that ship Swift in the OS (Darwin), and on Linux we should be emitting the stable ABI version of code. If this broke a test, a PR would be great and I can take a look.

3405691582 added a commit to 3405691582/swift that referenced this pull request Jul 1, 2020
@3405691582
[test] Add OpenBSD to stable ABI testing targets.
a7679c0 
See swiftlang#30391, swiftlang#30296. Neither IRGen/conditional_conformances.swift nor
IRGen/class_resilience.swift pass on OpenBSD unless
target_mandates_stable_abi = TRUE.
@3405691582 3405691582 mentioned this pull request Jul 1, 2020
Merged
3405691582 added a commit to 3405691582/swift that referenced this pull request Dec 11, 2020
@3405691582
[5.3] Add OpenBSD to stable ABI testing targets.
effe6b8 
See swiftlang#30391, swiftlang#30296. Neither IRGen/conditional_conformances.swift nor
IRGen/class_resilience.swift pass on OpenBSD unless
target_mandates_stable_abi = TRUE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubamracek @drodriguez